Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add settingDefaults to sample config #9919

Merged
merged 2 commits into from
Oct 7, 2019
Merged

add settingDefaults to sample config #9919

merged 2 commits into from
Oct 7, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented May 31, 2019 •
edited
Loading

@bwindels bwindels mentioned this pull request May 31, 2019
Merged
@bwindels bwindels requested a review from a team October 1, 2019 13:24
turt2live
turt2live approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

@bwindels bwindels force-pushed the bwindels/settings-config-doc branch 2 times, most recently from 726e9f8 to 259ca06 Compare October 7, 2019 13:11
@bwindels
Copy link
Contributor Author

bwindels commented Oct 7, 2019

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

Added breadcrumbs as example, and should already be documented at https://github.com/vector-im/riot-web/blob/develop/docs/config.md

@bwindels bwindels merged commit 57e597e into develop Oct 7, 2019
@turt2live
Copy link
Member

ah, so it is - thanks!

@t3chguy t3chguy deleted the bwindels/settings-config-doc branch May 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwindels @turt2live